Restrict with_exprt to exactly three operands #8674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
requested review from
peterschrammel,
TGWDB,
kroening and
martin-cs
as code owners
tautschnig
force-pushed
the
three-operand-with
branch
3 times, most recently
from
f4a850d to
d8fc072
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8674 +/- ##
===========================================
+ Coverage 80.39% 80.40% +0.01%
===========================================
Files 1688 1688
Lines 207387 207380 -7
Branches 73 73
===========================================
+ Hits 166728 166744 +16
+ Misses 40659 40636 -23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Test results for this branch running on mldsa-native/main are all good. |
|
Test results for this branch running on mlkem-native/main are all good. |
tautschnig
added
bugfix
soundness
This is in preparation of moving to 3-operand with-expressions: without intervening use of the simplifier some generated expressions could become unnecessarily large.
We cannot build a C++ API for the previous >= 3, odd-number operand variant. Alas, we ended up with various places in the code base silently ignoring additional operands, which led to wrong verification results in Kani as recent changes in CBMC made increasing use of the value set (which is one of the places that silently ignored additional operands). Resolves: diffblue#7272
tautschnig
force-pushed
the
three-operand-with
branch
from
d8fc072 to
fc5c5a0
Compare
kroening
approved these changes
Jul 9, 2025
peterschrammel
approved these changes
Jul 9, 2025
3 tasks
tautschnig
added a commit
to tautschnig/cbmc
that referenced
this pull request
Jul 9, 2025
This release addresses bugs in our handling of array-update ("with")
expressions (via diffblue#8674) and gaps in our C17/C23 support (via diffblue#8673).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cannot build a C++ API for the previous >= 3, odd-number operand variant. Alas, we ended up with various places in the code base silently ignoring additional operands, which led to wrong verification results in Kani as recent changes in CBMC made increasing use of the value set (which is one of the places that silently ignored additional operands).
This is an alternative solution over #8668: #8668 does also fix the wrong verification results, but does not resolve original design problem. This PR now seeks to address both the bug and the design problem, and does so by largely just removing code.
Resolves: #7272